Re: [PATCH] vacuumdb: Add --exclude-database option - Mailing list pgsql-hackers

From Ben Mejia
Subject Re: [PATCH] vacuumdb: Add --exclude-database option
Date
Msg-id 178164630022.991.17103275074682108158.pgcf@coridan.postgresql.org
Whole thread
Responses Re: [PATCH] vacuumdb: Add --exclude-database option
List pgsql-hackers
I think that the behavior of this patch that silently ignores --exlcude-database "non-existent-db" is broken. What if
someonehas a large database "my-db-name", and they misspell it:
 

$ vacuumdb --all --exclude-database "my-dbname"

This will kick off a vacuum including the "my-db-name" they were trying to exclude.

I think it would be better to generate an error and not do anything in this case.

This also tracks with vacuumdb's existing behavior on --table/--schema which will tell you about a typo.

pgsql-hackers by date:

Previous
From: Alexander Nestorov
Date:
Subject: Re: Multi-Entry Indexing for GiST & SP-GiST
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Fix segmentation fault and infinite loop in jsonb_{plperl,plpython}