The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested
The newly introduced check_cursor_name() implements the logic to reject empty cursor names, which matches the existing
checksin PerformCursorOpen() and PerformPortalFetch().
However, this helper function is not a good fit for PerformPortalClose(). At the start of this function, there is a
checkfor name == NULL — a NULL name corresponds to the CLOSE ALL command — and this check runs prior to validating
whetherthe name is an empty string.
While calling check_cursor_name() inside PerformPortalClose() would keep the current behavior intact, it could confuse
futurereaders. This approach also fails to achieve truly consistent cursor name validation across all three functions,
andmay add extra maintenance burdens in the long term.
On the other hand, if we only refactor PerformCursorOpen() and PerformPortalFetch(), the change would end up being
ratherminimal.
Considering all these factors, I'd suggest leaving the code as it is and skipping this refactoring.
