Re: pgsql: Rework option set of vacuumlo - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Rework option set of vacuumlo
Date
Msg-id 17758.1535490505@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Rework option set of vacuumlo  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Rework option set of vacuumlo  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers
I wrote:
> Digging, this is because the "make check" processing isn't actually
> installing oid2name (resp. vacuumlo) into the temp installation tree :-(.
> 
> I don't think this is the fault of your tests, exactly --- there's
> something wrong in the existing make rules.  I'm not sure what though.
> EXTRA_INSTALL should be getting set, according to pgxs.mk:
> temp-install: EXTRA_INSTALL+=$(subdir)
> but it evidently isn't.

Oh!  The reason why not is that that line is inside "ifdef REGRESS",
and these subdirectories have no REGRESS tests.  So we should move
that out to where it will apply regardless of that.  Will fix.

            regards, tom lane


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Rework option set of vacuumlo
Next
From: Tom Lane
Date:
Subject: pgsql: Include contrib modules in the temp installation even withoutRE