Re: [PATCHES] Charset WIN1252 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Charset WIN1252
Date
Msg-id 17743.1102274060@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Charset WIN1252  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> OK, good summary.  Shame we missed this for 8.0.  I am sure we will do
> better next time..  Wow, you had been working on this since November
> 2nd.  Shame it didn't make it.  Sorry again.

A minimum requirement for accepting an updated patch is that it should
hit all the same places where "grep" finds references to the other
WIN125? encodings.  Aside from the missed lookup-table update that I
complained of, I observe that the patch failed to update documentation
or test cases; neither of those omissions is acceptable.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Andreas Pflug
Date:
Subject: Re: Error: column "nsptablespace" does not exist
Next
From: Thomas Hallgren
Date:
Subject: Need access to a Linux box