Re: [PATCH] psql: add size-based sorting options (O/o) for tables and indexes - Mailing list pgsql-hackers

From Mahmoud Ayman
Subject Re: [PATCH] psql: add size-based sorting options (O/o) for tables and indexes
Date
Msg-id 176515293850.1475507.11035112220448679287.pgcf@coridan.postgresql.org
Whole thread Raw
In response to Re: [PATCH] psql: add size-based sorting options (O/o) for tables and indexes  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            not tested

Hi,

I tested the patch on top of current master. It applies cleanly and
builds without any issues.

I tried the new options with \dt and \di after creating tables and
indexes of different sizes. Both 'O' (desc) and 'o' (asc) work as
expected and the default behavior without these flags is unchanged.

Functionality looks good to me.

Regards,
Mahmoud Ayman

The new status of this patch is: Ready for Committer

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY
Next
From: David Rowley
Date:
Subject: Re: Fix incorrect comments in tuplesort.c