Re: Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.
Date
Msg-id 17631.1293383861@sss.pgh.pa.us
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.  (Robert Haas <robertmhaas@gmail.com>)
Responses autogenerating error code lists (was Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.)  (Jan Urbański <wulczer@wulczer.org>)
Re: Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Sun, Dec 26, 2010 at 8:03 AM, Jan Urbański <wulczer@wulczer.org> wrote:
>> See
>> https://github.com/wulczer/postgres/commit/44fc42b7708f23483156e4e0e1e321e68b2a7e2d#diff-0
>> for something that maybe could be used as a basis to autogenerate
>> errcodes.sgml and plerrcodes.h.

> Interesting.  It looks like this might be even easier with perl.

The reason those files aren't autogenerated already is that at the time,
we had a policy of not requiring perl during a build.  Now that that
restriction has gone down the drain, it might be worth thinking about.

> Proposed patch attached.  This adds what I believe to be the correct
> incantations to errcodes.sgml and plerrcodes.h, and also corrects a
> typographical error in yesterday's commit which I failed to notice
> while reviewing.

Hmm.  Even with the typo fixed, ERRCODE_FDW_UNABLE_TO_CREATE_EXECUTION
seems pretty darn opaque.  Is it missing a word?  Can we rephrase it so
people will have some idea what it means?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: MULTISET patch
Next
From: Tom Lane
Date:
Subject: C++ keywords in headers (was Re: [GENERAL] #include )