Re: "rejected" vs "returned with feedback" in new CF app - Mailing list pgsql-hackers

From Tom Lane
Subject Re: "rejected" vs "returned with feedback" in new CF app
Date
Msg-id 1761.1428582045@sss.pgh.pa.us
Whole thread Raw
In response to Re: "rejected" vs "returned with feedback" in new CF app  (Magnus Hagander <magnus@hagander.net>)
Responses Re: "rejected" vs "returned with feedback" in new CF app
Re: "rejected" vs "returned with feedback" in new CF app
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> On Apr 9, 2015 2:20 AM, "Robert Haas" <robertmhaas@gmail.com> wrote:
>> +1.

> Is that at +1 for naming it moved, or for not having it? :-)

> I can definitely go with moved. Buy I would like to keep it - the reason
> for having it in the first place is to make the history of the patch follow
> along when it goes to the next cf. If we don't have the move option, I
> think it's likely that we'll be back to the same patch having multiple
> completely unrelated entries in different cfs.

The problem with the whole thing is that you're asking the person doing
the "returned" marking to guess whether the patch will be resubmitted in
a future CF.

The right workflow here, IMO, is that a patch should be marked returned or
rejected, full stop; and then when/if the author submits a new version for
a future CF, there should be a way *at that time* to re-link the email
thread into that future CF.

"Moved" is really only applicable, I think, for cases where we punt a
patch to the next CF for lack of time.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: NOT NULL markings for BKI columns
Next
From: Kouhei Kaigai
Date:
Subject: Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API)