Re: Make pgoutput documentation easier to find - Mailing list pgsql-hackers

From Chao Li
Subject Re: Make pgoutput documentation easier to find
Date
Msg-id 175514428026.994.9355658453872400400.pgcf@coridan.postgresql.org
Whole thread Raw
Responses Re: Make pgoutput documentation easier to find
List pgsql-hackers
I applied the batch and built the html docs. I tested that all hyperlinks worked for me.

There are a few nit comments about wording:

diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml
index 593f784b69d..4516650983d 100644
--- a/doc/src/sgml/logicaldecoding.sgml
+++ b/doc/src/sgml/logicaldecoding.sgml

+    <xref linkend="test-decoding"/>.  You can also write custom output plugins

nit: "write" -> "develop"

+         Protocol version. Currently versions <literal>1</literal>, <literal>2</literal>,

"Protocol version." -> "Specifies the protocol version."

+         Comma-separated list of publication names for which to subscribe
+         (receive changes). The individual publication names are treated

A comma-separated list of publication names to subscribe to. The individual publication names are treated

+         Boolean option to use binary transfer mode.  Binary mode is faster

nit: "use" -> "enable", as other places all use "enable"

diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index e56eac8fd0f..9fe48c5acad 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml

+   The <literal>START_REPLICATION</literal> command allows us to
+   pass options to the logical decoding output plugin associated with
+   the replication slot specified in the command.
+   See <xref linkend="logicaldecoding-pgoutput-options"/> for options
+   that are accepted by the standard (<literal>pgoutput</literal>) plugin.

nit: The START_REPLICATION command can pass options to the logical decoding output plugin associated with the specified
replicationslot. See Section 47.6.1.1 for the options supported by the standard (pgoutput) plugin. 

The new status of this patch is: Waiting on Author

pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Conflict detection for update_deleted in logical replication
Next
From: Fujii Masao
Date:
Subject: Re: Excessive LOG messages from replication slot sync worker