Request a Demo
Home   >   mailing lists

Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain
Date
Msg-id 175163.1766357334@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain
List pgsql-hackers
Tree view 
Thomas Munro <thomas.munro@gmail.com> writes:
> I pushed the cleanup patch.

fairywren's still not happy, though only in the v16 branch:

Could not determine contrib module type for test_cloexec
 at build.pl line 54.

This evidently is because the old MSVC build system doesn't
recognize

PROGRAM += test_cloexec
OBJS += $(WIN32RES) test_cloexec.o

Is there a reason for using += not just = here?  We could certainly
modify Mkvcbuild.pm to parse this if we need to, but it looks more
like a gratuitous difference from everyplace else than a useful
behavior.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
Next
From: Michael Paquier
Date:
Subject: Re: Orphaned records in pg_replication_origin_status after subscription drop