Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w
Date
Msg-id 17499.1285462359@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w  (David Fetter <david@fetter.org>)
List pgsql-committers
David Fetter <david@fetter.org> writes:
> On Sat, Sep 25, 2010 at 11:04:28PM +0000, Tom Lane wrote:
>> The previous coding would decide that join removal was unsafe upon
>> finding a PlaceHolderVar that needed to be evaluated at the inner
>> rel and then used above the join.  However, this fails to cover the
>> case of PlaceHolderVars that refer to both the inner rel and some
>> other rels.  Per bug report from Andrus.

> The person who found it originally was Kirill (xitology) Simonov.  He
> brought it up in IRC. :)

[ shrug ... ]  I can only go by what I see in the bug report.

            regards, tom lane

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Minor improvements to git_changelog.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Fix man page markup for with multiple variants