Re: Erroneous -Werror=missing-braces on old GCC - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Erroneous -Werror=missing-braces on old GCC
Date
Msg-id 1749748.1703478229@sss.pgh.pa.us
Whole thread Raw
In response to Re: Erroneous -Werror=missing-braces on old GCC  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I wrote:
> Richard Guo <guofenglinux@gmail.com> writes:
>> I came across the 'missing braces' warning again when building master
>> (0a93f803f4) on old GCC (4.8.5).

> On the one hand, it's probably pointless to worry about buggy
> warnings from ancient compilers ...

Actually, after checking the buildfarm, I see that

arowana
ayu
batfish
boa
buri
demoiselle
dhole
dragonet
idiacanthus
lapwing
mantid
petalura
rhinoceros
shelduck
siskin
tanager
topminnow
xenodermus

are all bitching about this (with a couple different spellings
of the warning).  So this is absolutely something to fix, and
I'm rather surprised that nobody noticed it during the development
of 174c48050.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Erroneous -Werror=missing-braces on old GCC
Next
From: Kyotaro Horiguchi
Date:
Subject: pg_basebackup has an accidentaly separated help message