Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: get_names_for_var didn't do recursion for - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: get_names_for_var didn't do recursion for
Date
Msg-id 17413.1105656956@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: get_names_for_var didn't do recursion for  (Alvaro Herrera <alvherre@dcc.uchile.cl>)
List pgsql-committers
Tree view 
Alvaro Herrera <alvherre@dcc.uchile.cl> writes:
>> get_names_for_var didn't do recursion for unnamed JOIN vars quite right;
>> got it wrong when the JOIN was in an outer query level.  Per example from
>> Laurie Burrow.  Also fix same issue in markTargetListOrigin.  I think the
>> latter is only a latent bug since we currently don't apply
>> markTargetListOrigin
>> except at the outer level ... but should do it right anyway.

> BTW, this code is almost verbatim in 7.4.  Do you want me to patch it
> back?

In markTargetListOrigin you mean?  I think it's unnecessary, but if
you want to...

            regards, tom lane

pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgsql: get_names_for_var didn't do recursion for
Next
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql: Change exec_eval_simple_expr's param list allocation call from