Re: Exposing PG_VERSION_NUM in pg_config - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Exposing PG_VERSION_NUM in pg_config
Date
Msg-id 17371.1427309444@sss.pgh.pa.us
Whole thread Raw
In response to Re: Exposing PG_VERSION_NUM in pg_config  (Jim Nasby <Jim.Nasby@BlueTreble.com>)
Responses Re: Exposing PG_VERSION_NUM in pg_config
List pgsql-hackers
Jim Nasby <Jim.Nasby@BlueTreble.com> writes:
> On 3/24/15 6:26 PM, Tom Lane wrote:
>> Hm.  We're all agreed that there's a use case for exposing PG_VERSION_NUM
>> to the makefiles, but I did not hear one for adding it to pg_config; and
>> doing the former takes about two lines whereas adding a pg_config option
>> entails quite a lot of overhead (documentation, translatable help text,
>> yadda yadda).  So I'm not in favor of doing the latter without a much
>> more solid case than has been made.

> Why else would you want the version number other than to do some kind of 
> comparison?

The question is why, if we supply the version number in a make variable,
you would not just use that variable instead of having to do
"$(shell $(PG_CONFIG) --something)".  The shell version adds new failure
modes, removes none, and has no redeeming social value that I can see.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: deparsing utility commands
Next
From: Andres Freund
Date:
Subject: Re: Exposing PG_VERSION_NUM in pg_config