Re: 8.0.0 pg_restore -L doesn't restore ACLs - Mailing list pgsql-bugs

From Tom Lane
Subject Re: 8.0.0 pg_restore -L doesn't restore ACLs
Date
Msg-id 17362.1106439568@sss.pgh.pa.us
Whole thread Raw
In response to 8.0.0 pg_restore -L doesn't restore ACLs  (Michael Fuhr <mike@fuhr.org>)
Responses Re: 8.0.0 pg_restore -L doesn't restore ACLs  (Michael Fuhr <mike@fuhr.org>)
Re: 8.0.0 pg_restore -L doesn't restore ACLs  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
Michael Fuhr <mike@fuhr.org> writes:
> PostgreSQL 8.0.0
> Running "pg_restore -l" to create a list file and then restoring
> using "pg_restore -L" fails to restore ACLs.  See the "Privileges
> where [sic] not restored" thread in pgsql-admin:
> http://archives.postgresql.org/pgsql-admin/2005-01/msg00197.php

No doubt this is because the -l option doesn't list ACL entries in the
first place :-(.

A quick fix for the immediate issue would be to pass acl_pass as true
instead of false in PrintTOCSummary (pg_backup_archiver.c line 712 in
current sources).  I wonder however why PrintTOCSummary is filtering the
TOC entries at all, and whether there are any other cases that it really
shouldn't be filtering out.  Philip, do you remember why it's like that?

            regards, tom lane

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #1426: pg_restore SIGSEGV on 7.2.2 dump
Next
From: Tom Lane
Date:
Subject: Re: 8.0 doesn't dump index tablespace correctly.