Re: Making tab-complete.c easier to maintain - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Making tab-complete.c easier to maintain
Date
Msg-id 17239.1451956418@sss.pgh.pa.us
Whole thread Raw
In response to Re: Making tab-complete.c easier to maintain  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Making tab-complete.c easier to maintain
Re: Making tab-complete.c easier to maintain
List pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> So, here are the commands that still remain with TailMatches to cover
> this case, per gram.y:
> - CREATE TABLE
> - CREATE INDEX
> - CREATE VIEW
> - GRANT
> - CREATE TRIGGER
> - CREATE SEQUENCE
> New patches are attached.

I've reviewed and committed the first of these patches.  I found a few
mistakes, mostly where you'd converted TailMatches to Matches without
adding the leading words that the original author had left out of the
pattern.  But man, this is mind-numbingly tedious work :-(.  I probably
made a few more mistakes myself.  Still, the code is enormously more
readable now than when we started, and almost certainly more reliable.

I'm too burned out to look at the second patch tonight, but hopefully
will get to it tomorrow.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: remove wal_level archive
Next
From: Dilip Kumar
Date:
Subject: Re: parallel joins, and better parallel explain