Re: Use LN_S instead of "ln -s" in Makefile - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Use LN_S instead of "ln -s" in Makefile
Date
Msg-id 17230.1581731167@sss.pgh.pa.us
Whole thread Raw
In response to Re: Use LN_S instead of "ln -s" in Makefile  (Ashwin Agrawal <aagrawal@pivotal.io>)
List pgsql-hackers
Ashwin Agrawal <aagrawal@pivotal.io> writes:
> On Fri, Feb 14, 2020 at 4:57 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hm.  So, these oversights are certainly bugs in narrow terms.  However,
>> they've all been like that for a *long* time --- the three instances
>> you found date to 2005, 2006, and 2008 according to "git blame".
>> The complete lack of complaints shows that nobody cares.  So I think
>> a fairly strong case could be made for going the other way, ie
>> s/$(LN_S)/ln -s/g and get rid of the configure-time cycles wasted in
>> setting up that variable.

> I accede to it.

Oh ... 2005 was just the last time anybody touched that particular
line in backend/Makefile.  Further digging shows that we've been
installing the postmaster -> postgres symlink with raw "ln -s"
clear back to the Postgres95 virgin sources.  I didn't bother to
chase down the oldest instances of the other two cases.

(Man, "git blame" is such a great tool for software archaeology.)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Ashwin Agrawal
Date:
Subject: Re: Use LN_S instead of "ln -s" in Makefile
Next
From: Bryn Llewellyn
Date:
Subject: jsonb_object() seems to be buggy. jsonb_build_object() is good.