Re: [PATCH] Round 2: Magic block for modules - Mailing list pgsql-patches

From Tom Lane
Subject Re: [PATCH] Round 2: Magic block for modules
Date
Msg-id 17221.1149020049@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Round 2: Magic block for modules  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [PATCH] Round 2: Magic block for modules  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Patch applied.  Thanks.

I hadn't gotten around to reviewing the revised version.  Just to let
you know, I'm going to remove the separate header file pgmagic.h and
put the macro into fmgr.h as I'd suggested originally.  The reason is
that the separate file turns the problem of making backward-compatible
modules from a simple "#ifdef PG_MAGIC_BLOCK" into a big does-that-
header-exist autoconf pushup.  It's not worth that.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Neil Conway"
Date:
Subject: Re: PL/PGSQL: Dynamic Record Introspection
Next
From: Andrew Dunstan
Date:
Subject: Re: [PATCH] Round 2: Magic block for modules