Re: Bug in StartupSUBTRANS - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Bug in StartupSUBTRANS
Date
Msg-id 17161.1455043504@sss.pgh.pa.us
Whole thread Raw
In response to Re: Bug in StartupSUBTRANS  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: Bug in StartupSUBTRANS
List pgsql-hackers
Simon Riggs <simon@2ndQuadrant.com> writes:
> Your patch looks right to me, so I will commit, barring objections... with
> backpatch. Likely to 9.0, AFAICS.

9.0 is out of support and should not be patched anymore.

I agree that the patch is basically correct, though I'd personally
write it without bothering with the extra variable:

+    /* must account for wraparound */
+    if (startPage > TransactionIdToPage(0xFFFFFFFF))
+        startPage = 0;

Also, the comment at line 45 is now wrong and needs an addition.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Bug in StartupSUBTRANS
Next
From: Tom Lane
Date:
Subject: Re: Tracing down buildfarm "postmaster does not shut down" failures