Re: pgsql: Minor pg_dump improvements - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Minor pg_dump improvements
Date
Msg-id 17153.1391969032@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Minor pg_dump improvements  (Stephen Frost <sfrost@snowman.net>)
Responses Re: pgsql: Minor pg_dump improvements  (Stephen Frost <sfrost@snowman.net>)
List pgsql-committers
Stephen Frost <sfrost@snowman.net> writes:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>> I'm pretty sure you broke _CloseArchive with this hunk:

> That'd be pretty frustrating as my testing didn't exhibit any issues.

It's possible that errno is accidentally zero when we get there, but
the code as-committed surely can't be called bulletproof.

            regards, tom lane


pgsql-committers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: pgsql: Minor pg_dump improvements
Next
From: Stephen Frost
Date:
Subject: pgsql: Focus on ftello result < 0 instead of errno