Re: Vacuuming the operating system documentation - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Vacuuming the operating system documentation
Date
Msg-id 1712669.1591501370@sss.pgh.pa.us
Whole thread Raw
In response to Re: Vacuuming the operating system documentation  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Vacuuming the operating system documentation  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> Yeah, I wasn't planning on changing anything in backbranches.  It
> sounds like we're OK with doing this for 13.  Here's a version with a
> few more changes:

Looks pretty good to me.  I attach a delta patch with a few more
proposed adjustments.  Notably, I made the wording about /etc/sysctl.conf
for Linux match that for other OSes, except I said "see" not
"modify" because (at least on my Red Hat based installations)
the comments in /etc/sysctl.conf direct you to modify various
sub-files.

> ... I am aware of one modern kernel that ships
> pre-built without SysV IPC: Android, but apparently this stuff is also
> missing from its libc so you won't get this far.

Yeah, ISTR some prior discussion about that on our lists.
If anyone's trying to run PG on their phone, they probably
do not need help from these docs.

            regards, tom lane

diff --git a/doc/src/sgml/runtime.sgml b/doc/src/sgml/runtime.sgml
index 927f062abe..1b2012d34a 100644
--- a/doc/src/sgml/runtime.sgml
+++ b/doc/src/sgml/runtime.sgml
@@ -539,7 +539,7 @@ DETAIL:  Failed system call was shmget(key=5440001, size=4011376640, 03600).
      probably means your kernel's limit on the size of shared memory is
      smaller than the work area <productname>PostgreSQL</productname>
      is trying to create (4011376640 bytes in this example).
-     This is more likely to happen if you have set <literal>shared_memory_type</literal>
+     This is only likely to happen if you have set <literal>shared_memory_type</literal>
      to <literal>sysv</literal>.  In that case, you
      can try starting the server with a smaller-than-normal number of
      buffers (<xref linkend="guc-shared-buffers"/>), or
@@ -1009,8 +1009,8 @@ psql: could not connect to server: No such file or directory
 <prompt>$</prompt> <userinput>sysctl -w kernel.shmmax=17179869184</userinput>
 <prompt>$</prompt> <userinput>sysctl -w kernel.shmall=4194304</userinput>
 </screen>
-        These settings can be preserved between reboots in
-        the file <filename>/etc/sysctl.conf</filename>.
+        To make these settings persist over reboots, see
+        <filename>/etc/sysctl.conf</filename>.
        </para>

       </listitem>
@@ -1287,7 +1287,7 @@ default:\
    </indexterm>

    <para>
-    The default virtual memory behavior is not
+    The default virtual memory behavior on Linux is not
     optimal for <productname>PostgreSQL</productname>. Because of the
     way that the kernel implements memory overcommit, the kernel might
     terminate the <productname>PostgreSQL</productname> postmaster (the

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Vacuuming the operating system documentation
Next
From: Tom Lane
Date:
Subject: Re: valgrind error