On 3/21/17 23:34, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> No answer. Can we remove this chunk?
>
>>> + if (no_role_passwords && binary_upgrade)
>
> Perhaps, but why? ISTM that trying to run pg_upgrade as non-superuser
> is a nonstarter for a number of reasons, while if you're superuser you
> do not need --no-role-passwords.
Well, this code was added, apparently without reason. We don't need to
actively prohibit option combinations just because they are unusual.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
