Re: BUG #6061: Progresql.exe memory usage using HOLD cursor. - Mailing list pgsql-bugs

From Delorme, Yann
Subject Re: BUG #6061: Progresql.exe memory usage using HOLD cursor.
Date
Msg-id 16940004307E8140B1AFF255B4C3B860FF9F@LY-EX10-MB-1.esker.corp
Whole thread Raw
In response to Re: BUG #6061: Progresql.exe memory usage using HOLD cursor.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: BUG #6061: Progresql.exe memory usage using HOLD cursor.
List pgsql-bugs
Thanks

Do you think that it will be fix in future release 9.1 ?=20

Regards,=20

Yann


Yann Delorme
Senior Software Engineer / Senior Software Engineer
Esker SA
T=C3=A9l : +33 (0)4 72 83 46 46

Fax : + 33 (0)4 72 83 46 40
mailto:Yann.Delorme@esker.fr
http://www.esker.fr/ =E2=96=A0 http://www.flydoc.fr/

CONFIDENTIALITE : Ce message et les =C3=A9ventuelles pi=C3=A8ces jointes so=
nt confidentiels. Si vous n'=C3=AAtes pas dans la liste des destinataires, =
veuillez informer l'exp=C3=A9diteur imm=C3=A9diatement et ne pas divulguer =
le contenu =C3=A0 une tierce personne. Les id=C3=A9es et opinions pr=C3=A9s=
ent=C3=A9es dans ce message sont celles de son auteur, et ne repr=C3=A9sent=
ent pas n=C3=A9cessairement celles de la soci=C3=A9t=C3=A9. Par ailleurs et=
 malgr=C3=A9 toutes les pr=C3=A9cautions prises pour =C3=A9viter la pr=C3=
=A9sence de virus dans nos envois, nous vous recommandons de prendre, de vo=
tre c=C3=B4t=C3=A9, les mesures permettant d'assurer la non-introduction de=
 virus dans votre syst=C3=A8me informatique. La soci=C3=A9t=C3=A9 ne saurai=
t =C3=AAtre tenue pour responsable de tout dommage caus=C3=A9 par la pr=C3=
=A9sence d'un virus dans ce message.
__________
-----Message d'origine-----

De : Tom Lane [mailto:tgl@sss.pgh.pa.us]=20
Envoy=C3=A9 : mercredi 15 juin 2011 18:43
=C3=80 : Delorme, Yann
Cc : pgsql-bugs@postgresql.org
Objet : Re: [BUGS] BUG #6061: Progresql.exe memory usage using HOLD cursor.=
=20

"Yann" <yann.delorme@esker.fr> writes:
> The issue is that in this case all rows are store in memory instead of=20
> file in the process postgresql.exe

> I think the issue is in the file tuplestore.c.
> When a tuple is added the function static void=20
> tuplestore_puttuple_common(Tuplestorestate *state, void *tuple),=20
> USEMEM is not called with tuple size.

Hmm ... yeah, I think there's a leak there.

> I think that, after adding the tuple in the array, a call to USEMEM=20
> should be done.

No, the callers of tuplestore_puttuple_common are supposed to do that.
But it looks like tuplestore_putvalues() forgot to do so.  So data loads th=
at go through that particular API would miss incrementing the space counter.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #6062: psql terminates on auto-complete
Next
From: Guillaume Smet
Date:
Subject: Re: BUG #6061: Progresql.exe memory usage using HOLD cursor.