Re: [HACKERS] md.c is feeling much better now, thank you - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] md.c is feeling much better now, thank you
Date
Msg-id 16914.936627162@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] md.c is feeling much better now, thank you  (Tatsuo Ishii <t-ishii@sra.co.jp>)
List pgsql-hackers
Tatsuo Ishii <t-ishii@sra.co.jp> writes:
>> Hmm.  It seems a more straightforward solution would be to alter
>> pg_parse_and_plan so that the parser isn't even called if we have
>> already failed the current transaction; that is, the "queries ignored"
>> test should occur sooner.  I'm rather surprised to realize that
>> we do run the parser in this situation...

> No. we have to run the parser so that we could accept "end".

Ah, very good point.  I stand corrected.

>>>> Until that I propose following solution. It looks
>>>> simple, safe and would be neccessary anyway (I don't know why that
>>>> check had not been implemented). See included patches.
>> 
>> This looks like it might be a good change, but I'm not quite as sure
>> as you are that it won't have any bad effects.  Have you tested it?
>
> At least initdb and the regression test runs fine for me...

Same here.  I have committed it into current, but not REL6_5.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Leon
Date:
Subject: Re: [HACKERS] DROP TABLE inside transaction block
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] DROP TABLE inside transaction block