Anyone for adding -fwrapv to our standard CFLAGS? - Mailing list pgsql-hackers

From Tom Lane
Subject Anyone for adding -fwrapv to our standard CFLAGS?
Date
Msg-id 1689.1134422394@sss.pgh.pa.us
Whole thread Raw
Responses Re: Anyone for adding -fwrapv to our standard CFLAGS?  (Neil Conway <neilc@samurai.com>)
List pgsql-hackers
It seems that gcc is up to some creative reinterpretation of basic C
semantics again; specifically, you can no longer trust that traditional
C semantics of integer overflow hold:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175462

While I don't think we are anywhere using exactly the same trick that
the referenced mysql code is using, it certainly seems likely to me that
a compiler that is willing to replace "x < 0 && -x < 0" with "false"
might be able to break some of the integer overflow checks we do use.

I think we need to add -fwrapv to CFLAGS anytime the compiler will take
it, same as we recently started doing with -fno-strict-aliasing.

Comments?
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Francisco Figueiredo Jr."
Date:
Subject: [Bug] Server Crash, possible security exploit, where to send security report?
Next
From: "Cristian Prieto"
Date:
Subject: replan needed?