Mark Dilger <mark.dilger@enterprisedb.com> writes:
> Regardless of which of 1..4 you pick, I think it could all do with more regression test coverage.
Indeed. If we have no regression tests that reach this code, it's
folly to touch it at all, but most especially so post-feature-freeze.
I think the *first* order of business ought to be to create some
test cases that reach this area. Perhaps they'll be too expensive
to incorporate in our regular regression tests, but we could still
use them to investigate Mark's concerns.
regards, tom lane
