Re: Some whitespaces in utility.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Some whitespaces in utility.c
Date
Msg-id 16819.1346769307@sss.pgh.pa.us
Whole thread Raw
In response to Re: Some whitespaces in utility.c  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Some whitespaces in utility.c
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> On Tue, Sep 4, 2012 at 6:57 AM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> I found some whitespace characters in utility.c introduced by commit
>> 3a0e4d3.
>> Please find attached a patch fixing that which can be applied on postgres
>> master (commit 2f0c7d5).

> That probably exists in many other places in the source as well, but
> it's certainly fairly ugly. So I see nothing wrong cleaning it up whe
> nspotted.

Just as a note: we generally leave it to pgindent to fix this sort of
thing.  I'm not sure it's worth the effort of submitting manual patches
for, unless you have reason to think the next pgindent run won't fix it.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_dump incorrect output in plaintext mode
Next
From: Alvaro Herrera
Date:
Subject: Re: pg_upgrade del/rmdir path fix