Re: Inconsistency in plpgsql's error context reports - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Inconsistency in plpgsql's error context reports
Date
Msg-id 16763.1513014382@sss.pgh.pa.us
Whole thread Raw
In response to Re: Inconsistency in plpgsql's error context reports  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Inconsistency in plpgsql's error context reports
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Sun, Dec 10, 2017 at 11:55 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> There seem to be two ways we could look at this.  One is that the
>> new test case just needs to be rejiggered to avoid unstable output
>> ("\set VERBOSITY terse" would be the easiest way).  But there is
>> also room to argue that it's bad that plpgsql produces error reports
>> that vary depending on the phase of the moon, which is pretty much
>> what this would look like in the field --- cache flushes will occur
>> unpredictably in most application environments.

> I am inclined toward the latter view.

Yeah, me too.  I'll see about patching exec_eval_simple_expr() to
provide a context line that matches SPI's.  Seems like a HEAD-only
change though, as this will result in visible behavior change in
the typical case.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Custom compression methods
Next
From: Robert Haas
Date:
Subject: Re: Mention ordered datums in PartitionBoundInfoData comment