Re: Let's get rid of SPI_push/SPI_pop - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Let's get rid of SPI_push/SPI_pop
Date
Msg-id 16696.1478530048@sss.pgh.pa.us
Whole thread Raw
In response to Re: Let's get rid of SPI_push/SPI_pop  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: Let's get rid of SPI_push/SPI_pop  (Pavel Stehule <pavel.stehule@gmail.com>)
Re: Let's get rid of SPI_push/SPI_pop  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Pavel Stehule <pavel.stehule@gmail.com> writes:
> 2016-11-07 2:16 GMT+01:00 Tom Lane <tgl@sss.pgh.pa.us>:
>> So I think we should just delete these functions and adjust SPI_connect
>> and SPI_finish so that they just push/pop a context level unconditionally.
>> (Which will make them simpler, not more complicated.)

> cannot be there some performance impacts?

Any impact will be for the better, since we're removing logic.
I haven't gone through it in detail, but it might be as simple
as removing _SPI_curid and code that manipulates it.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Streaming basebackups vs pg_stat_tmp
Next
From: Peter Eisentraut
Date:
Subject: Re: [COMMITTERS] pgsql: pg_xlogdump: Add NLS