Re: Small bug on CREATE EXTENSION pgq... - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Small bug on CREATE EXTENSION pgq...
Date
Msg-id 16695.1422505551@sss.pgh.pa.us
Whole thread Raw
In response to Re: Small bug on CREATE EXTENSION pgq...  (Stephen Frost <sfrost@snowman.net>)
Responses Re: Small bug on CREATE EXTENSION pgq...
List pgsql-hackers
Stephen Frost <sfrost@snowman.net> writes:
> * David Johnston (david.g.johnston@gmail.com) wrote:
>> Fair enough but "reset" to what?  I don't know the internal mechanics but
>> if the session default is "warning" and a local change sets it to "notice"
>> then an unconditional reset would not get us back to the intended value.

> Yeah, we'd really want to reset it to "what it was before."

An extension script runs as a single transaction, so SET LOCAL could've
been used to accomplish the result without trashing the session-lifespan
setting.

I'm not sure whether or not there was good reason to be changing the
setting at all, but it's entirely on the extension script's head that
it didn't do this in a less invasive way.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Possible typo in create_policy.sgml
Next
From: Josh Berkus
Date:
Subject: Re: pg_upgrade and rsync