Re: Patch: add timing of buffer I/O requests - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Patch: add timing of buffer I/O requests
Date
Msg-id 1663.1334368876@sss.pgh.pa.us
Whole thread Raw
In response to Re: Patch: add timing of buffer I/O requests  (Greg Stark <stark@mit.edu>)
Responses Re: Patch: add timing of buffer I/O requests  (Peter Geoghegan <peter@2ndquadrant.com>)
Re: Patch: add timing of buffer I/O requests  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Greg Stark <stark@mit.edu> writes:
> On Fri, Apr 13, 2012 at 8:15 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> That's probably true, but I'm not sure it's worth worrying about -
>> one-in-four-billion is a pretty small probability.

> Is this not subject to the birthday paradox? If you have a given hash
> you're worried about a collision with then you have a
> one-in-four-billion chance. But if you have a collection of hashes and
> you're worried about any collisions then it only takes about 64k
> before there's likely a collision.

... so, if pg_stat_statements.max were set as high as 64k, you would
need to worry.

Realistically, I'm more worried about collisions due to inadequacies in
the jumble calculation logic (Peter already pointed out some risk
factors in that regard).
        regards, tom lane


pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: Patch: add timing of buffer I/O requests
Next
From: Pavel Stehule
Date:
Subject: Re: [BUGS] BUG #6572: The example of SPI_execute is bogus