Re: COMMENT ON [GROUP/USER] - Mailing list pgsql-hackers

From Tom Lane
Subject Re: COMMENT ON [GROUP/USER]
Date
Msg-id 16483.1078781677@sss.pgh.pa.us
Whole thread Raw
In response to Re: COMMENT ON [GROUP/USER]  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> This doesn't look good.  If we throw a WARNING, why do we not insert
> anything into pg_description.  Seems we should throw an error, or do the
> insert with a warning.

Throwing an error breaks existing pg_dump files.  Doing the insertion is
simply wrong: it will allow the former breakage to be perpetuated
forward by dump/reload.  Thus the current behavior is an unfortunate but
necessary compromise ... at least until we have better support for
comments on databases.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: COMMENT ON [GROUP/USER]
Next
From: "scott.marlowe"
Date:
Subject: Re: question about selecting across multiple dbs