Re: The dbase conrtib doesn't compile - Mailing list pgsql-hackers

From Tom Lane
Subject Re: The dbase conrtib doesn't compile
Date
Msg-id 16450.1008911560@sss.pgh.pa.us
Whole thread Raw
In response to Re: The dbase conrtib doesn't compile  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: The dbase conrtib doesn't compile  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Yes, glad you pointed it out.  I think the best solution is to remove
> #define HAVE_ICONV_H and -liconv so it will work fine on all platforms. 
> If someone wants the iconv conversions, they can add the needed #define
> and link library, OK?

That seems like a plan.  Perhaps add some commented-out macro
definitions to the makefile to make it a simple addition.  Something
like

# Uncomment this to provide charset translation
# CFLAGS += -DHAVE_ICONV_H
# You might need to uncomment this too, if libiconv is a separate
# library on your platform
# LIBS += -liconv

Untested but you get the idea ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: The dbase conrtib doesn't compile
Next
From: Bruce Momjian
Date:
Subject: Re: The dbase conrtib doesn't compile