Re: Add on_perl_init and proper destruction to plperl [PATCH] - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add on_perl_init and proper destruction to plperl [PATCH]
Date
Msg-id 16442.1264634870@sss.pgh.pa.us
Whole thread Raw
In response to Re: Add on_perl_init and proper destruction to plperl [PATCH]  (Tim Bunce <Tim.Bunce@pobox.com>)
Responses Re: Add on_perl_init and proper destruction to plperl [PATCH]  (Tim Bunce <Tim.Bunce@pobox.com>)
List pgsql-hackers
Tim Bunce <Tim.Bunce@pobox.com> writes:
> Okay. I could change the callback code to ignore calls if
> proc_exit_inprogress is false. So an abnormal shutdown via exit()
> wouldn't involve plperl at all. (Alternatively I could use use
> on_proc_exit() instead of atexit() to register the callback.)

Use on_proc_exit please.  I will continue to object to any attempt
to hang arbitrary processing on atexit().

An advantage of on_proc_exit from your end is that it should allow
you to not have to try to prevent the END blocks from using SPI,
as that would still be perfectly functional when your callback
gets called.  (Starting a new transaction would be a good idea
though, cf Async_UnlistenOnExit.)
        regards, tom lane


pgsql-hackers by date:

Previous
From: "David E. Wheeler"
Date:
Subject: Re: Add on_perl_init and proper destruction to plperl [PATCH]
Next
From: Tom Lane
Date:
Subject: Re: Add on_perl_init and proper destruction to plperl [PATCH]