Re: pg_upgrade using appname to lock out other users - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_upgrade using appname to lock out other users
Date
Msg-id 16362.1308108673@sss.pgh.pa.us
Whole thread Raw
In response to pg_upgrade using appname to lock out other users  (Bruce Momjian <bruce@momjian.us>)
Responses Re: pg_upgrade using appname to lock out other users
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> You might remember we added a postmaster/postgres -b switch to indicate
> binary upgrade mode.  The attached patch prevents any client without an
> application_name of 'binary-upgrade' from connecting to the cluster
> while it is binary upgrade mode.  This helps prevent unauthorized users
> from connecting during the upgrade.  This will not help for clusters
> that do not have the -b flag, e.g. pre-9.1.

> Does this seem useful?

No ... that seems like a kluge.  It's ugly and it's leaky.

What we really ought to be doing here is fixing things so that
pg_upgrade does not need to have a running postmaster in either
installation, but works with some variant of standalone mode.
That would actually be *safe* against concurrent connections,
rather than only sorta kinda maybe safe.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Hitoshi Harada
Date:
Subject: planinstr, showing planner time on EXPLAIN
Next
From: Bruce Momjian
Date:
Subject: Re: pg_upgrade using appname to lock out other users