Re: The suppress_redundant_updates_trigger() works incorrectly - Mailing list pgsql-hackers

From Tom Lane
Subject Re: The suppress_redundant_updates_trigger() works incorrectly
Date
Msg-id 16335.1225979237@sss.pgh.pa.us
Whole thread Raw
In response to Re: The suppress_redundant_updates_trigger() works incorrectly  (KaiGai Kohei <kaigai@ak.jp.nec.com>)
Responses Re: The suppress_redundant_updates_trigger() works incorrectly  (KaiGai Kohei <kaigai@kaigai.gr.jp>)
List pgsql-hackers
KaiGai Kohei <kaigai@ak.jp.nec.com> writes:
> Andrew Dunstan wrote:
>> Wouldn't this omit comparing the null bitmap?

> Oops, I added the comparison of null bitmap here.

That's really, really ugly code.  Why would it be necessary anyway?
Shouldn't the security tag be expected to match?  I suppose that it
should be possible to alter a security tag with UPDATE, and that means
it cannot work the way OID does anyway.  In a sane implementation the
field would already be valid before the triggers fire.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: plperl needs upgrade for Fedora 10
Next
From: Tom Lane
Date:
Subject: Re: [WIP] In-place upgrade