Re[5]: On login trigger: take three - Mailing list pgsql-hackers

From Ivan Panchenko
Subject Re[5]: On login trigger: take three
Date
Msg-id 1629126702.671868768@f133.i.mail.ru
Whole thread Raw
In response to Re: Re[3]: On login trigger: take three  (Greg Nancarrow <gregn4422@gmail.com>)
Responses Re: Re[5]: On login trigger: take three
List pgsql-hackers
 
Hi Greg,
 
Среда, 7 июля 2021, 3:55 +03:00 от Greg Nancarrow <gregn4422@gmail.com>:
 
On Sun, Jul 4, 2021 at 1:21 PM vignesh C <vignesh21@gmail.com> wrote:
>
> CFBot shows the following failure:
> # poll_query_until timed out executing this query:
> # SELECT '0/3046250' <= replay_lsn AND state = 'streaming' FROM
> pg_catalog.pg_stat_replication WHERE application_name = 'standby_1';
> # expecting this output:
> # t
> # last actual query output:
> # t
> # with stderr:
> # NOTICE: You are welcome!
> # Looks like your test exited with 29 before it could output anything.
> t/001_stream_rep.pl ..................
> Dubious, test returned 29 (wstat 7424, 0x1d00)
>

Thanks.
I found that the patch was broken by commit f452aaf7d (the part
"adjust poll_query_until to insist on empty stderr as well as a stdout
match").
So I had to remove a "RAISE NOTICE" (which was just an informational
message) from the login trigger function, to satisfy the new
poll_query_until expectations.

Does it mean that "RAISE NOTICE" should’t be used, or behaves unexpectedly in logon triggers? Should we mention this in the docs?
 
Regards,
Ivan Panchenko
Also, I updated a PG14 version check (now must check PG15 version).

Regards,
Greg Nancarrow
Fujitsu Australia
 

pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode
Next
From: John Naylor
Date:
Subject: Re: badly calculated width of emoji in psql