Request a Demo
Home   >   mailing lists

Re: [PATCH] Use DatumGetUInt32() for dsm_attach() in test_shm_mq_main() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Use DatumGetUInt32() for dsm_attach() in test_shm_mq_main()
Date
Msg-id 1623653.1751025792@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Use DatumGetUInt32() for dsm_attach() in test_shm_mq_main()  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
Tree view 
Nathan Bossart <nathandbossart@gmail.com> writes:
> On Thu, Jun 26, 2025 at 01:46:10PM -0700, Jianghua Yang wrote:
>> These errors trace back to failures in `dsm_attach()`, where the
>> segment handle value was incorrectly interpreted due to sign extension
>> from `int32`.

> I think there might be something else going on.

I agree with Nathan: the patch you proposed is purely cosmetic.
I don't object to it, but you need to dig deeper because this
will not resolve any actual behavioral problem.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Daniil Davydov
Date:
Subject: Re: Prevent internal error at concurrent CREATE OR REPLACE FUNCTION
Next
From: Ryo Kanbayashi
Date:
Subject: Re: [PATCH] PGSERVICEFILE as part of a normal connection string