Magnus Hagander <magnus@hagander.net> writes:
> On Fri, Nov 9, 2018 at 2:21 AM Michael Paquier <michael@paquier.xyz> wrote:
>> On Thu, Nov 08, 2018 at 11:31:41AM +0100, Magnus Hagander wrote:
>>> ... why is this problem only showing up now?
> Oh, i didn't realize that wasn't run by the buildfarm. Then yeah, it's
> pretty likely it was simply never run.
IIRC, the reason those tests aren't run by default is that they're
pointless unless executed in a hot-standby configuration. I'm inclined to
think we should remove them from src/test/regress altogether, and instead
put equivalent checks (for any not-already-covered case) into one of the
TAP tests that sets up such a configuration. src/test/recovery is
probably the right home.
regards, tom lane