The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
The patch applies cleanly and looks fine to me. However consider this scenario.
- CREATE SCHEMA foo;
- CREATE EXTENSION file_fdw WITH SCHEMA foo;
- pg_dump --file=/tmp/test.sql --exclude-schema=foo postgres
This will still include the extension 'file_fdw' in the backup script. Shouldn't it be excluded as well?
The new status of this patch is: Waiting on Author
