Re: pgsql: Remove unused wait events. - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: pgsql: Remove unused wait events.
Date
Msg-id 1611CCCC-E0E8-4A74-A95B-80ECCE987145@yesql.se
Whole thread Raw
In response to Re: pgsql: Remove unused wait events.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Remove unused wait events.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> On 25 Oct 2021, at 19:18, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Robert Haas <robertmhaas@gmail.com> writes:
>> ... But while I agree it's good to remove unused stuff in the
>> master, it doesn't seem like we really need to back-patch it.
>
> Yeah, exactly.  I don't see any benefit that's commensurate with
> even a small risk of breaking extensions --- and apparently, in
> this case that's not a risk but a certainty.

Since this will cause integer values to have different textual enum value
representations in 14 and 15+, do we want to skip two numbers by assigning the
next wait event the integer value of WAIT_EVENT_WAL_WRITE incremented by three?
Or enum integer reuse not something we guarantee against across major versions?

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats().
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Remove unused wait events.