Re: pgsql: Code review for foreign/custom join pushdown patch. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Code review for foreign/custom join pushdown patch.
Date
Msg-id 16109.1431306848@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Code review for foreign/custom join pushdown patch.  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> On 2015-05-10 18:36:45 +0000, Tom Lane wrote:
>> * Consider foreign joins only between foreign tables on the same server,
>> rather than between any two foreign tables with the same underlying FDW
>> handler function.  In most if not all cases, the FDW would simply have had
>> to apply the same-server restriction itself (far more expensively, both for
>> lack of caching and because it would be repeated for each combination of
>> input sub-joins), or else risk nasty bugs.  Anyone who's really intent on
>> doing something outside this restriction can always use the
>> set_join_pathlist_hook.

> Hm. I'm not sure I can agree with that judgement. It does not seem that
> far fetched to want to push joins between two different FDW servers to
> one FDW.

What I doubt is that people can do that *correctly*.  See my
counterexamples in the pgsql-hackers thread.  In any case, as also noted
on that thread, an FDW that wants to adjust this behavior could do so by
changing RelOptInfo.serverid to match the ID of the selected common server
during GetForeignPaths.

            regards, tom lane


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Code review for foreign/custom join pushdown patch.
Next
From: Robert Haas
Date:
Subject: pgsql: Fix DetermineSafeOldestOffset for the case where there are no mx