On Monday, July 25, 2016 7:12:11 AM CEST Inoue, Hiroshi wrote:
> It's difficult to revert the commit because the functionality exists
> before 9.5.
> I'm inclined to omit 2 cases in trouble from param-conversions-test for
> the time being.
> Is it OK?
As I understand the problem, the regression test caught real issue ...
i.e. there is (a) bug fixed but (b) new regression added.
I'm not able to measure what issue is more serious, but the fixed bug 'a'
is looks like related to very small subset of users, while 'b' is related to
everybody ...
... so (when the revert is no-go) rather than removing the tests completely,
I would suggest you to mark them as "expected failure" and wait for the fix in
future. I'm fine to keep that patch reverted downstream for the time being.
I'm glad have fixes for the portability issues, I can't wait for having it
committed!
Pavel
