Re: Generating configure from configure.ac - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Generating configure from configure.ac
Date
Msg-id 1598141.1732597679@sss.pgh.pa.us
Whole thread Raw
In response to Re: Generating configure from configure.ac  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Generating configure from configure.ac
List pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> . o O ( I wonder if that missing Debian/Ubuntu bugfix[1] is why our
> AIX animals have -D_LARGE_FILES=1 jammed into $CC, even though
> AC_SYS_LARGEFILES claims to understand AIX )

I'm dubious.  The two likely results if off_t is 32 bits are
(1) the compiler shifts the 1 off into never-never land, producing
zero, or (2) the compiler throws an error about shift distance too
large.  Either one will lead to the test failing as-desired.
Yeah, the C spec theoretically licenses the compiler to halt
and catch fire, but that's not going to happen in practice.
(Thus Sven Joachim's doubt in the linked bug discussion that
anything is actually broken.)

It seems plausible to me that the -D_LARGE_FILES=1 settings in our
AIX animals' configuration are carried over from some dim past where
we didn't have this configure test, or it was implemented even less
correctly than now.  I wonder whether Noah has any records of their
origin.

            regards, tom lane



pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Parallel heap vacuum
Next
From: Bertrand Drouvot
Date:
Subject: Re: Potential ABI breakage in upcoming minor releases