Re: insert performance for win32 - Mailing list pgsql-performance

From Tom Lane
Subject Re: insert performance for win32
Date
Msg-id 15926.1131127280@sss.pgh.pa.us
Whole thread Raw
In response to Re: insert performance for win32  ("Merlin Moncure" <merlin.moncure@rcsonline.com>)
Responses Re: insert performance for win32
List pgsql-performance
"Merlin Moncure" <merlin.moncure@rcsonline.com> writes:
> Nailed it.

> problem is in mainloop.c -> setup_cancel_handler.  Apparently you can
> have multiple handlers and windows keeps track of them all, even if they
> do the same thing.  Keeping track of so many system handles would
> naturally slow the whole process down.

Yipes.  So we really want to do that only once.

AFAICS it is appropriate to move the sigsetjmp and setup_cancel_handler
calls in front of the per-line loop inside MainLoop --- can anyone see
a reason not to?

I'm inclined to treat this as an outright bug, not just a minor
performance issue, because it implies that a sufficiently long psql
script would probably crash a Windows machine.

            regards, tom lane

pgsql-performance by date:

Previous
From: "Merlin Moncure"
Date:
Subject: Re: insert performance for win32
Next
From: "Merlin Moncure"
Date:
Subject: Re: insert performance for win32