Re: Remove redundant code in pl_exec.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Remove redundant code in pl_exec.c
Date
Msg-id 159144.1662742673@sss.pgh.pa.us
Whole thread Raw
In response to Re: Remove redundant code in pl_exec.c  (Japin Li <japinli@hotmail.com>)
List pgsql-hackers
Japin Li <japinli@hotmail.com> writes:
> On Fri, 09 Sep 2022 at 23:34, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I don't like this particularly --- it puts way too much premium on
>> the happenstance that the MakeExpandedObjectReadOnly call is the
>> very last step in the callback function.  If that needed to change,
>> we'd have a mess.

> Sorry, I don't get your mind.  Could you explain it more?  Thanks in advance!

This refactoring cannot support the situation where there is more
code to execute after MakeExpandedObjectReadOnly.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: is_superuser is not documented
Next
From: Nathan Bossart
Date:
Subject: Re: Switching XLog source from archive to streaming when primary available