Re: Fix memleaks and error handling in jsonb_plpython - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fix memleaks and error handling in jsonb_plpython
Date
Msg-id 15889.1554587784@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fix memleaks and error handling in jsonb_plpython  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Fix memleaks and error handling in jsonb_plpython
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Mar 06, 2019 at 11:04:23AM +0900, Michael Paquier wrote:
>> Another thing is that you cannot just return within a try block with
>> what is added in PLyObject_FromJsonbContainer, or the error stack is
>> not reset properly.  So they should be replaced by breaks.

> So, I have been poking at this stuff, and I am finishing with the
> attached.

This patch had bit-rotted due to somebody else fooling with the
volatile-qualifiers situation.  I fixed it up, tweaked a couple of
things, and pushed it.

> Also, as all those
> problems are really unlikely going to happen in real-life cases,
> improving this code only on HEAD looks enough to me.

Yeah, I concur.

            regards, tom lane



pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: INSTALL file
Next
From: Alexander Korotkov
Date:
Subject: Re: jsonpath