Re: After upgrading libpq, the same function(PQftype) call returns a different OID - Mailing list pgsql-general

From Tom Lane
Subject Re: After upgrading libpq, the same function(PQftype) call returns a different OID
Date
Msg-id 1586473.1742583372@sss.pgh.pa.us
Whole thread Raw
In response to Re: After upgrading libpq, the same function(PQftype) call returns a different OID  ("David G. Johnston" <david.g.johnston@gmail.com>)
List pgsql-general
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Thu, Mar 20, 2025 at 2:56 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> That's documented elsewhere, I believe.  For the foo_d.h files,
>> I think it'd be sufficient to do something like 0001 attached.

> WFM.  Thanks.

Thanks for looking at it.

>> Also, while checking out the results, I noticed that pg_class.h
>> has an "extern" in the wrong place: it's exposed to client code
>> which can have no use for it.  That extern doesn't mention any
>> backend-only typedefs, so it's fairly harmless, but it's still
>> a clear example of somebody not reading the memo.  Hence 0002.

> Maybe tack this onto genbki.h?

> diff --git a/src/include/catalog/genbki.h b/src/include/catalog/genbki.h
> index 26e205529d..4a1567a46b 100644
> --- a/src/include/catalog/genbki.h
> +++ b/src/include/catalog/genbki.h
> @@ -146,4 +146,6 @@
>   */
>  #undef EXPOSE_TO_CLIENT_CODE

> +/* Additional backend-only code is placed after the client-code section. */
> +
>  #endif                                                 /* GENBKI_H */

Doubt that would help ...

            regards, tom lane



pgsql-general by date:

Previous
From: Dimitrios Apostolou
Date:
Subject: Re: Experience and feedback on pg_restore --data-only
Next
From: Ron Johnson
Date:
Subject: Re: Experience and feedback on pg_restore --data-only