Re: Buildfarm now building but with test failures - Mailing list pgsql-jdbc

From Tom Lane
Subject Re: Buildfarm now building but with test failures
Date
Msg-id 15826.1325694391@sss.pgh.pa.us
Whole thread Raw
In response to Buildfarm now building but with test failures  ("Mike Fowler" <mike@mlfowler.com>)
Responses Re: Buildfarm now building but with test failures
List pgsql-jdbc
"Mike Fowler" <mike@mlfowler.com> writes:
> HEAD is failing in a completely different way. A sample from the logs:
> [junit] ERROR: language "SQL" does not exist

I believe that's something Robert changed recently.  We used to forcibly
downcase language names even if quoted, but he successfully argued that
that was inconsistent and unnecessary.  So I'm guessing your test suite
contains CREATE FUNCTION ... LANGUAGE "SQL", and you should remove the
quotes.

[ digs in logs... ]  Ah, here we are:

Author: Robert Haas <rhaas@postgresql.org>
Branch: master [67dc4eed4] 2011-11-17 14:25:18 -0500

    Remove ancient downcasing code from procedural language operations.

    A very long time ago, language names were specified as literals rather
    than identifiers, so this code was added to do case-folding.  But that
    style has ben deprecated for many years so this isn't needed any more.
    Language names will still be downcased when specified as unquoted
    identifiers, but quoted identifiers or the old style using string
    literals will be left as-is.

            regards, tom lane

pgsql-jdbc by date:

Previous
From: Dave Cramer
Date:
Subject: Re: Buildfarm now building but with test failures
Next
From: Dave Cramer
Date:
Subject: Fwd: Re: Buildfarm now building but with test failures