Re: create_help.pl treats as replaceable - Mailing list pgsql-hackers

From Tom Lane
Subject Re: create_help.pl treats as replaceable
Date
Msg-id 1581685.1652800163@sss.pgh.pa.us
Whole thread Raw
In response to create_help.pl treats as replaceable  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: create_help.pl treats as replaceable  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Re: create_help.pl treats as replaceable  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> I found it annoying that sql_help.c contains a literal parameter as a
> translatable string.

> The cause is that create_help.pl treats <literal>match</> as a
> replaceable. The attached excludes literals from translatable strings.

> By a quick look it seems to me that the "match" in "COPY.. HEADER
> match" is the first and only instance of a literal parameter as of
> PG15.

Isn't that a documentation bug rather than a problem with create_help?
I see what you're talking about:

    HEADER [ <replaceable class="parameter">boolean</replaceable> | <literal>match</literal> ]

but that just seems flat-out wrong.  If "match" is a keyword it should
be rendered like other keywords.  I'm not very interested in splitting
hairs about whether the grammar thinks it is a keyword --- it looks like
one to a user.  So I think

    HEADER [ <replaceable class="parameter">boolean</replaceable> | MATCH ]

would be a better solution.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: PostgreSQL 15 Beta 1 release announcement draft
Next
From: Tomas Vondra
Date:
Subject: Re: Collecting statistics about contents of JSONB columns