Re: Bogus reports from coverage.postgresql.org - Mailing list pgsql-www

From Tom Lane
Subject Re: Bogus reports from coverage.postgresql.org
Date
Msg-id 15758.1520656953@sss.pgh.pa.us
Whole thread Raw
In response to Re: Bogus reports from coverage.postgresql.org  (Andres Freund <andres@anarazel.de>)
List pgsql-www
Andres Freund <andres@anarazel.de> writes:
> On 2018-03-09 19:36:28 -0500, Tom Lane wrote:
>> I happened to notice that if you look at
>> https://coverage.postgresql.org/src/backend/optimizer/util/predtest.c.gcov.html
>> it claims that the two occurrences of
>> elog(ERROR, "predicate_classify returned a bogus value");
>> at lines 492 and 803 are reached.

> Is it possible that the compiler figured that the patch is unreachable
> and removed the code?

Maybe, but then it's even less reasonable to claim that the lines
were reached.

In general, lcov seems to ignore lines for which no code was generated,
which is fine by me.

            regards, tom lane


pgsql-www by date:

Previous
From: Andres Freund
Date:
Subject: Re: Bogus reports from coverage.postgresql.org
Next
From: Alvaro Herrera
Date:
Subject: Re: Bogus reports from coverage.postgresql.org